Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(codegen): move Result appending into type generation #6082

Merged
merged 1 commit into from
Mar 20, 2024
Merged

refactor(codegen): move Result appending into type generation #6082

merged 1 commit into from
Mar 20, 2024
+5 −19

Conversation

sgulseth
Copy link
Member

@sgulseth sgulseth commented Mar 20, 2024 •
edited
Loading

Description

Moves Result appending to the type identifier into the type generation. This way we can keep the actual query name across usages.

What to review

Testing

👍

Notes for release

N/A - no notes needed

@vercel Vercel
Copy link

vercel bot commented Mar 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Mar 20, 2024 0:57am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2024 0:57am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Mar 20, 2024 0:57am

@sgulseth sgulseth requested a review from kmelve March 20, 2024 12:50
@sgulseth Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sgulseth and the rest of your teammates on Graphite Graphite

@sgulseth sgulseth marked this pull request as ready for review March 20, 2024 12:51
@sgulseth sgulseth requested a review from a team as a code owner March 20, 2024 12:51
@sgulseth sgulseth requested review from bjoerge and removed request for a team March 20, 2024 12:51
kmelve
kmelve approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@kmelve kmelve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛥️

@github-actions GitHub Actions
Copy link
Contributor

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

Component Testing Report Updated Mar 20, 2024 12:59 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 35s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 12s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 31s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 0s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 0s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 19s 9 0 0

@sgulseth sgulseth added this pull request to the merge queue Mar 20, 2024
Merged via the queue into next with commit 63432da Mar 20, 2024
34 of 35 checks passed
@sgulseth sgulseth deleted the 03-20-refactor_codegen_move_result_appending_into_type_generation branch March 20, 2024 13:01
hermanwikner pushed a commit that referenced this pull request Mar 21, 2024
@sgulseth @hermanwikner
refactor(codegen): move Result appending into type generation (#6082)
a679c23
hermanwikner pushed a commit that referenced this pull request Mar 21, 2024
@sgulseth @hermanwikner
refactor(codegen): move Result appending into type generation (#6082)
53a84a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmelve kmelve kmelve approved these changes

@bjoerge bjoerge Awaiting requested review from bjoerge bjoerge was automatically assigned from sanity-io/sdk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgulseth @kmelve